osmith submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved
coverity: don't build tests for all

The coverity jenkins job has been failing since we tried to build tests
for all projects (and in an earlier attempt, build and run tests for all
projects). Make the coverity job work again by skipping build of tests
for asn1c. I looked into it earlier and the cause wasn't obvious to me,
and it's currently not worth spending time on.

Fix for:
libtool: error: cannot find the library '../../skeletons/libasn1cskeletons.la' or unhandled argument '../../skeletons/libasn1cskeletons.la'

Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951
---
M coverity/prepare_source_Osmocom.sh
1 file changed, 41 insertions(+), 35 deletions(-)

diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh
index 11b7e5c..01e3d73 100755
--- a/coverity/prepare_source_Osmocom.sh
+++ b/coverity/prepare_source_Osmocom.sh
@@ -1,42 +1,46 @@
#!/bin/sh
BASEDIR=source-Osmocom

+PROJECTS="
+ libasn1c
+ libosmo-abis
+ libosmocore
+ libosmo-dsp
+ libosmo-netif
+ libosmo-sccp
+ libsmpp34
+ libusrp
+ osmo-bsc
+ osmo-msc
+ osmo-mgw
+ osmo-ggsn
+ osmo-gbproxy
+ osmo-sgsn
+ osmo-bts
+ osmo-gmr
+ osmo-iuh
+ osmo-pcu
+ osmo-sysmon
+ osmo-sip-connector
+ osmo-trx
+ osmo-hlr
+ osmocom-bb
+ osmo-smlc
+ osmo-cbc
+ simtrace2
+ osmo-hnodeb
+ osmo-hnbgw
+ osmo-bsc-nat
+"
+
+PROJECTS_DONT_BUILD_TEST="
+ asn1c
+"
+
[ -d $BASEDIR ] || mkdir -p $BASEDIR
cd $BASEDIR

-for proj in \
- asn1c \
- libasn1c \
- libosmo-abis \
- libosmocore \
- libosmo-dsp \
- libosmo-netif \
- libosmo-sccp \
- libsmpp34 \
- libusrp \
- osmo-bsc \
- osmo-msc \
- osmo-mgw \
- osmo-ggsn \
- osmo-gbproxy \
- osmo-sgsn \
- osmo-bts \
- osmo-gmr \
- osmo-iuh \
- osmo-pcu \
- osmo-sysmon \
- osmo-sip-connector \
- osmo-trx \
- osmo-hlr \
- osmocom-bb \
- osmo-smlc \
- osmo-cbc \
- simtrace2 \
- osmo-hnodeb \
- osmo-hnbgw \
- osmo-bsc-nat \
- ; do
-
+for proj in $PROJECTS $PROJECTS_DONT_BUILD_TEST; do
if [ -d $proj ]; then
if [ -z "$SRC_SKIP_FETCH" ]; then
(cd $proj && git fetch && git checkout -f -B master origin/master)
@@ -47,9 +51,11 @@
else
git clone git://git.osmocom.org/$proj
fi
+done

- # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS'
- # instead of 'check_PROGRAMS' allows building test binaries during 'make all'.
+# We want to compile tests, but not execute them. Using 'noinst_PROGRAMS'
+# instead of 'check_PROGRAMS' allows building test binaries during 'make all'.
+for proj in $PROJECTS; do
files="$(git -C $proj grep -l check_PROGRAMS)"
if [ -n "$files" ]; then
(cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files)

To view, visit change 28576. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951
Gerrit-Change-Number: 28576
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged