Attention is currently required from: Hoernchen, laforge, pespin.

View Change

12 comments:

• File doc/manuals/chapters/ipc_if.adoc:

  • Patch Set #2, Line 113: @closed@

    this gets printed literally as @closed@ in the pdf, I guess it should be monospace `closed` instead?

  • Patch Set #2, Line 116: TIP: See

    Maybe move this TIP to the start of the section? Then the reader could open it next to this document and look at e.g. "struct ipc_sk_if_greeting" while reading about it in this document.

    Same with the TIP for "Channel UD Socket".
    Same with the TIP for "Posix Shared Memory format".

  • Patch Set #2, Line 170: +w

    missing space

  • Patch Set #2, Line 171: +w

    missing space

  • Patch Set #2, Line 223: ``

    `

  • Patch Set #2, Line 226: ``

    `

  • Patch Set #2, Line 275: `N``

    ```
    `N`
    ```

  • Patch Set #2, Line 283:

    . Read `buff->data_len` samples, reset the buffer data (`data_len=0``),
    increment `next_read` and if read samples is `<N``, continue with next buffer
    until `next_read==next_write``, then block again or if timeout elapsed, then  we
    reach conditon buffer underflow and `return len < N``.
    

    ```
    s/``/`/g
    ```

  • Patch Set #2, Line 290: `N``

    ```
    `N`
    ```

  • Patch Set #2, Line 300: next_write was == next_read

    is this written as intended, maybe "next_write prev" would be more clear?

  • Patch Set #2, Line 294:

    . Write samples to `buff = stream->buffers[next_write]`. If `data_len!=0``,
    signal `buffer_overflow`` (increase field in stream object) and probably
    increase next_read``.
    
    . Increase `next_write``.
    
    . If `next_write was == next_read``, signal the reader through the other
    semaphore that it can continue reading.
    

    ```
    s/``/`/g
    ```

• File doc/manuals/chapters/trx-backends.adoc:

  • Patch Set #2, Line 132:

    * Test and experiment with _osmo-trx-ipc_.
    * Write your own IPC _Driver_ connecting to osmo-trx-ipc.
    

    these do not show up as bullet points in the pdf

To view, visit change 36465. To unsubscribe, or for help writing mail filters, visit settings.