Attention is currently required from: neels, dexter.

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #8, Line 401: * a tentative decision is made.

    1) The decision is made for both directions and each side keeps the result in end.codec. […]

    1) ack for dexter. In an endpoint there's 2 connections (sides), and there's 2 directions on each conn, one Tx and one Rx. A decision has to be taken for each conn Tx direction (hence 2 decisions).

    2) ack for dexter. UDP connections exists I see no weird use in there. In any case in here we talk about mgcp_conn(_rtp).

    3) ack, we must choose when in loopback mode I guess.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #8, Line 511: rtp_hdr->payload_type = (uint8_t) conn_dst->end.codec->payload_type;

    I think there must be a consciously chosen payload type for each connection (endpoint is the entity […]

    ACK, AFAIU the PayloadType is assigned to a connection, not to an endpoint.

To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.