Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File include/osmocom/hnbgw/hnbgw.h:

  • Patch Set #3, Line 463: DECLARE_HASHTABLE(hnb_persistent_by_id, 5);

    is this 5 related to the one in mkhash_add()? if so, it may make sense to use a define, or some hash […]

    no, this is just how many bits to use for the hash table.
    That mkhash stuff is to get to something that this here can handle (up to 64 bit input)

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #4, Line 245: /* source: http://www.cse.yorku.ca/~oz/hash.html */

    I am not very sure about whether this here is the right way. Maybe we need a generic arbitrary-buffer-to-hash function, or maybe there already is one that I don't know about?

    Or maybe we can just feed the last 64 bit of the umts_cell_id to the hashtable's hash function?

To view, visit change 36889. To unsubscribe, or for help writing mail filters, visit settings.