Attention is currently required from: laforge, dexter.

View Change

6 comments:

• File src/osmo-hnbgw/context_map.c:

  • Patch Set #25, Line 142: /* a possibly still existing MGW FSM must be termiated when the context

    terminated

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #25, Line 50: * do not support at the moemnt. */

    moment

  • Patch Set #25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we cannot recover */

    Request

  • Patch Set #25, Line 53: static void tx_release_req(struct hnbgw_context_map *map)

    This function doesn't really look like belonging in this file. It should be oved somewhere Iu related, not here which is MGW related.

  • Patch Set #25, Line 424: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg,

    I'm still not understanding why is this resize here needed. Your previous answer didn't really explain it imho.
    Why do you need to resize if ranap_rab_ass_resp_encode gets passed msgb_l2len to make sure it doesn't overflow?

  • Patch Set #25, Line 627: static int handle_rab_release(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message)

    Same, this function doesn't really look like belonging in this file.

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.