Attention is currently required from: neels, laforge.
4 comments:
File include/osmocom/core/utils.h:
would be very helpful to include a brief explanation, sort of like "A modulo where the result always […]
As far as I can see this is not the only property of this modulo function. I don't think that this is helpful. Users are either aware of the mathematical properties and know whats going on here or they don't, then its better for them to look it up in the referenced paper. (I also can't claim for me to fully understand whats going on here, the more I am happy that the paper contains mathematical proofs and test vectors)
you neet to put braces around every single occurence of these parameters like […]
Done
"A modulo where the result is always positive" or something
(see above)
Patch Set #4, Line 195: y > 0 ? x % y + y : x % y - y
please put braces around this section. […]
Done
To view, visit change 30933. To unsubscribe, or for help writing mail filters, visit settings.