Attention is currently required from: canghaiwuhen.

View Change

15 comments:

• File src/sgsn/gprs_sm.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 214: uint8_t qos_len;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 214: uint8_t qos_len;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 215:

    trailing whitespace

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 215:

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 215:

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos))

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos))

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos))

    suspect code indent for conditional statements (8, 12)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 217: qos_len = sizeof(default_qos);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 217: qos_len = sizeof(default_qos);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 218: else

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 218: else

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 218: else

    suspect code indent for conditional statements (8, 12)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 219: qos_len = pdp->req_qos_len;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 219: qos_len = pdp->req_qos_len;

    please, no spaces at the start of a line

To view, visit change 41948. To unsubscribe, or for help writing mail filters, visit settings.