fixeria has uploaded this change for review.

View Change

mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH

The CHANNEL MODE MODIFY message only applies to TCH channels,
and in general should not arrive on non-traffic channels. Let's
print error message if this happens in order to facilitate
finding possible bugs.

Change-Id: I4ab63c4ae4262c8166de37e4873fc3f1b8ec6fe7
Related: OS#5599
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/30/30330/1

diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index e7722f1..e8c998d 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -3437,9 +3437,11 @@
 	}
 
 	/* only apply mode to TCH/F or TCH/H */
-	if (ch_type != RSL_CHAN_Bm_ACCHs
-	 && ch_type != RSL_CHAN_Lm_ACCHs)
+	if (ch_type != RSL_CHAN_Bm_ACCHs && ch_type != RSL_CHAN_Lm_ACCHs) {
+		LOGP(DRR, LOGL_ERROR, "CHANNEL MODE MODIFY only applies "
+			"to TCH channels, ignoring...\n");
 		return -ENOTSUP;
+	}
 
 	/* setting (new) timing advance */
 	LOGP(DRR, LOGL_INFO, "setting TCH mode to %s, audio mode to %d\n",

To view, visit change 30330. To unsubscribe, or for help writing mail filters, visit settings.