Attention is currently required from: laforge, dexter.
Patch set 12:Code-Review +1
3 comments:
Patchset:
Looks good now!
File tests/test_files.py:
Patch Set #12, Line 56: debug("Testing decode of %s" % name)
Not really critical (for tests), just a tip: documentation of the Python's logging framework recommends using lazy format-string composition instead of manual composition in-place. This can be achieved by passing format string arguments as arguments of the logging functions:
logging.debug("Testing decode of %s", name)
The idea is that the format string is evaluated only if it's actually going to be printed.
Patch Set #12, Line 160: for c in classes:
Can be done a bit simpler:
return filter(lambda c: c not in trans_rec_classes, classes)
Also, you can make it a class variable, so there would be no need to call get_classes() every time.
To view, visit change 24012. To unsubscribe, or for help writing mail filters, visit settings.