Attention is currently required from: pespin.

Patch set 3:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    A name of a rate_ctr could be a a string of digits. […]

    this is a valid point, wondering why it is marked resolved? unmarking.

    I thought it's good enough and simplest to implement ... but obviously didn't think it through.

    From the logic we use in

        rate_ctr.(abs|per_sec|...).hnb.[0-99].barred_foos
       
    I thought at first that I have to add an all new level, which i don't want, like this:

        ..hnb.by-idx.0.barred_foos
        ..hnb.by-id.901-70-C123.barred_foos
       
    i.e.

        ..hnb.(by-idx|by-id).IDX_OR_NAME.barred_foos
       
    because I want to keep the "hnb.0" command unchanged. i.e. not having to add an "by-idx" to all existing CTRL clients.

    Until now i thought that effort is not worth it -- but just now I notice that we can add only the 'by-id' keyword, because it's clearly distingushable from a plain integer.

    Allow these variants:

        rate_ctr.abs.hnb.0.barred_foos
        rate_ctr.abs.hnb.by-id.901-70-C123-etc.barred_foos

    what do you guys think is better naming, "by-id" or "by-name"?

To view, visit change 37881. To unsubscribe, or for help writing mail filters, visit settings.