Attention is currently required from: Hoernchen, dexter, lynxis lazus.

Patch set 3:Code-Review +1

View Change

1 comment:

• File pySim/global_platform/__init__.py:

  • Patch Set #3, Line 664: build_construct

    I am wondering why do you need `build_construct()` and why can't you just do `cls.KeyDataBasic.build(...)`? Also, why converting from plain bytes to hex? AFAICS, this hex-aware `GreedyBytes` from pyosmocom can handle plain bytes just fine.

To view, visit change 43136. To unsubscribe, or for help writing mail filters, visit settings.