falconia abandoned this change.
View Change
Abandoned
Based on comments from reviewers, I get the sense that the community consensus is to prefix the GSM 06.31 SID enum and its items with osmo_ even though it is not Osmo-defined, for the sake of namespace containment. In this case there is no need for a separate <osmocom/gsm/protocol/gsm_06_31.h> header.
To view, visit change 32197. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If004b668778d3d9cf6cd998b3af2dbfa83691529
Gerrit-Change-Number: 32197
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-MessageType: abandon