Attention is currently required from: dexter, fixeria.

View Change

3 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #1, Line 38: log = PySimLogger.get(__name__)

    I remember having problems here. This code location was not able to access the globel log object. […]

    this is odd, the code should have acces to global variabls of the same module. WE definitely don't want to pass the log object around explicitly.

• File contrib/csv-to-pgsql.py:

  • Patch Set #2, Line 15: log = PySimLogger.get("csv-to-pqsql")

    you can generalize this with
    ```
    from pathlib import Path
    print(Path(__file__).stem)
    ```

    this way it automatically adjusts if we should ever rename the script file.

• File contrib/es2p_server.py:

  • Patch Set #2, Line 35: logger = logging.getLogger("es2p_server")

    you can generalize this with
    ```
    from pathlib import Path
    print(Path(__file__).stem)
    ```

    this way it automatically adjusts if we should ever rename the script file.

To view, visit change 41890. To unsubscribe, or for help writing mail filters, visit settings.