Attention is currently required from: fixeria.

View Change

1 comment:

• File gen_makefile.py:

  • Patch Set #1, Line 247: if "_" in project:

    Wouldn't this turn `osmo_dia2gsup` into `osmo`?

    No, because this doesn't change `project` and because it checks if the resulting splitted string is a valid project from the `all.deps` file before attempting to placing it in the queue.

    With `osmo_dia2gsup` this happens:
    ```
    project_main = "osmo"
    if "osmo" in project_deps:  # -> False
      # this gets skipped
    # continue the same as without this change
    ```

To view, visit change 40978. To unsubscribe, or for help writing mail filters, visit settings.