Attention is currently required from: pespin.
View Change
1 comment:
File hlr/HLR_Tests.ttcn:
Patch Set #6, Line 1037: tr_GSUP_IE_APN('08'O & char2oct("internet"))
can we please have a "function str2apn(charstring str) return octetstring" for this please? :)
It makes it a lot more complicated. It is length encoded by dots.
(in python syntax)
E.g. internet -> b"\x08internet"
internet.fast -> b"\x08internet\x04fast".
I would keep it as simple here for now..
To view, visit change 32510. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989
Gerrit-Change-Number: 32510
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Tue, 23 May 2023 11:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment