laforge submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
contrib/smpp-ota-tool: add missing usage helpstrings

Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae
Related: OS#6868
---
M contrib/smpp-ota-tool.py
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py
index 0903533..02ddfc0 100755
--- a/contrib/smpp-ota-tool.py
+++ b/contrib/smpp-ota-tool.py
@@ -204,9 +204,9 @@
help="PoR check (rc=redundency check, cc=crypt. checksum, ds=digital signature)")
option_parser.add_argument("--por_req", choices=POR_REQ.decmapping.values(), default='por_required',
help="Proof of Receipt requirements")
- option_parser.add_argument('--src-addr', default='12', type=str, help='TODO')
- option_parser.add_argument('--dest-addr', default='23', type=str, help='TODO')
- option_parser.add_argument('--timeout', default=10, type=int, help='TODO')
+ option_parser.add_argument('--src-addr', default='12', type=str, help='SMS source address (MSISDN)')
+ option_parser.add_argument('--dest-addr', default='23', type=str, help='SMS destination address (MSISDN)')
+ option_parser.add_argument('--timeout', default=10, type=int, help='Maximum response waiting time')
option_parser.add_argument('-a', '--apdu', action='append', required=True, type=is_hexstr, help='C-APDU to send')
opts = option_parser.parse_args()


To view, visit change 42187. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae
Gerrit-Change-Number: 42187
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>