laforge submitted this change.

View Change



2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
library: as_pfcp_ignore(): log SeqNr of received PDUs

Printing the PFCP PDU template ('?' by default) is not very informative
when reading logs. Printing the message type of the received PDU is
not informative either, because message types are defined as numbers
in PFCP_Types.ttcn. Printing the whole PDU is way too verbose, and
would be redundant given that the PFCPEM component already does print
all received PDUs. Let's print the sequence number.

Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836
---
M library/PFCP_Emulation.ttcn
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn
index edb1f9c..892670c 100644
--- a/library/PFCP_Emulation.ttcn
+++ b/library/PFCP_Emulation.ttcn
@@ -392,8 +392,10 @@

altstep as_pfcp_ignore(PFCPEM_PT pt, template PDU_PFCP pfcp_expect := ?)
{
- [] pt.receive(pfcp_expect) {
- log("Ignoring ", pfcp_expect);
+ var PDU_PFCP pdu;
+
+ [] pt.receive(pfcp_expect) -> value pdu {
+ log("Ignoring PFCP PDU (SeqNr := ", pdu.sequence_number, ")");
repeat;
}
}

To view, visit change 38208. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836
Gerrit-Change-Number: 38208
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>