1 comment:
File src/osmo-hnbgw/hnbgw_hnbap.c:
Patch Set #1, Line 657: cause.present = HNBAP_Cause_PR_protocol;
The effect of our two variants is identical, it's a bikeshed.
No, it's not. In one you are writing all memory of the struct first and then again overwriting some fields, while in the other you do less writing. Please stop naming everything as bikeshed as a means to discard others comments systematically.
To view, visit change 37996. To unsubscribe, or for help writing mail filters, visit settings.