Attention is currently required from: jolly, pespin.

3 comments:

File include/osmocom/gsm/protocol/gsm_08_08.h:
- Patch Set #12, Line 175: BSS_MAP_MSG_UPLINK_REJECT_CMD = 75,
  (not critical: you only change the formatting here. Usually we put those changes in a follow up patch)
File src/gsm/gsm0808.c:
- Patch Set #12, Line 22: #ifdef HAVE_SYS_SOCKET_H
  As far as I understand from the discussion around patch-set 5, this is to prevent building this code on embedded targets. I would split this part into a patch preceding this one.
File tests/tlv/tlv_test.c:
- Patch Set #12, Line 4:
  TLV parsing should work on embedded targets. I can see that this has ties to gsm0808 (osmo_bssap_tlv_parse). If we could remove this dependency then we could include the tlv_test in embedded builds again.
  I also see an additional problem: This is a unit test. We probably run into problems when we just remove this for some builds. The output will change and no longer match the .ok and .err files. (But the build passes in jenkins, maybe it isn't a problem though...)

To view, visit change 32932. To unsubscribe, or for help writing mail filters, visit settings.