Attention is currently required from: dexter.
Patch set 12:Code-Review +1
View Change
1 comment:
File src/pcu_l1_if.cpp:
Patch Set #10, Line 277: if (imsi && strlen(imsi) >= IMSI_DIGITS_FOR_PAGING)
I forgot to remove the check above, now its only two times.
And you know what's better than 2 times? 1 time! you could take the chance to store the result in a var ;)
To view, visit change 31650. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40d7fc14c9591b3de091e425faaf325421c70a0e
Gerrit-Change-Number: 31650
Gerrit-PatchSet: 12
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 18:17:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment