Attention is currently required from: arehbein, daniel.

View Change

5 comments:

• File include/osmocom/netif/stream.h:

  • Patch Set #3, Line 48: struct osmo_stream_srv *osmo_stream_srv_create_iofd(void *ctx, const char *name, struct osmo_stream_srv_link *link, int fd, int (*read_cb)(struct osmo_stream_srv *conn, struct msgb *msg), int (*closed_cb)(struct osmo_stream_srv *conn), void *data);

    Does that mean use needs to use one or another depending on whether iofd is used? Probably that's not the case, so this one should be named osmo_stream_srv_create2.

    Maybe add extra APIs to set each callback instead.

  • Patch Set #3, Line 83: void osmo_stream_cli_set_iofd_read_cb(struct osmo_stream_cli *cli, int (*read_cb)(struct osmo_stream_cli *cli, struct msgb *msg));

    So for client you add a new setter API, but for srv you update an existing one? This looks strange.

  • Patch Set #3, Line 88: struct osmo_stream_cli *osmo_stream_cli_create_iofd(void *ctx, const char *name);

    osmo_stream_cli_create2 (no iofd specific)

• File src/stream.c:

  • Patch Set #3, Line 1360: #define OSMO_STREAM_SRV_F_FLUSH_DESTROY (1 << 0)

    Why is this code block moved from below to to here?
    You are mixing srv_link and srv code then.

  • Patch Set #3, Line 1610: rc = conn->read_cb(conn);

    Mayeb the read_cb rename can be done in a separate prior patch to simplify this one.

To view, visit change 33193. To unsubscribe, or for help writing mail filters, visit settings.