Attention is currently required from: jolly, laforge.

View Change

1 comment:

• File src/stream_cli.c:

  • Patch Set #4, Line 998: if (cli->state != STREAM_CLI_STATE_CONNECTED) {

    I think with the osmo_fd mode it is indeed just enqueued in our own internal write_queue which might […]

    But this is really breaking the behavior of the API, and it may have undesired consequences.

    Why aren't we still using the osmo_wqueue during this time and submitting enqueued data when we receive the connect signal from the kernel?

    I'm not enforcing one thing or the other, just sharing my concerns here.

To view, visit change 36123. To unsubscribe, or for help writing mail filters, visit settings.