laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve
rspro_client_fsm: Log clientConnectResult != ok

This should aid debugging.

Related: SYS#5950
Change-Id: I8f584640758be0cceab61dcb333c81374da3288b
---
M src/asn1c_helpers.h
M src/rspro_client_fsm.c
2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/asn1c_helpers.h b/src/asn1c_helpers.h
index 8d4e676..ac34a8f 100644
--- a/src/asn1c_helpers.h
+++ b/src/asn1c_helpers.h
@@ -1,5 +1,6 @@
#pragma once

+#include <asn_application.h>
struct asn_TYPE_descriptor_t;

const char *asn_type_name(const asn_TYPE_descriptor_t *td);
diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index bd07330..bd267ca 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -32,6 +32,7 @@
#include <osmocom/gsm/protocol/ipaccess.h>

#include "debug.h"
+#include "asn1c_helpers.h"
#include "rspro_client_fsm.h"

#define S(x) (1 << (x))
@@ -229,6 +230,8 @@
pdu = data;
res = rspro_get_result(pdu);
if (res != ResultCode_ok) {
+ LOGPFSML(fi, LOGL_ERROR, "Rx RSPRO connectClientRes(result=%s), closing\n",
+ asn_enum_name(&asn_DEF_ResultCode, res));
ipa_client_conn_close(srvc->conn);
osmo_fsm_inst_dispatch(fi, SRVC_E_TCP_DOWN, NULL);
} else {

To view, visit change 28056. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I8f584640758be0cceab61dcb333c81374da3288b
Gerrit-Change-Number: 28056
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged