Attention is currently required from: dexter.

View Change

1 comment:

• File tests/unittests/xo/test_configurable_parameters:

  • Patch Set #2, Line 4: read_back_val={'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr}

    Hmm. As far as I can see the changes here only change the formatting. […]

    This is is just some code tweak in a unit test, I'd appreciate if we can just pass it.

    Reasoning, if anyone is interested:

    this here already is the sparate commit.

    This patch shows that I am only changing the composition of the output without the expexted output files changing: the unit tests still pass with identical output.

    
    The point of the change is, when an exception happens, e.g. while implementing a new ConfigurableParameter: before, the error log doesn't show the value for which a parameter failed. This patch makes debugging much easier.

    the previous code also was quite weird, spaghetti artefact.

To view, visit change 43513. To unsubscribe, or for help writing mail filters, visit settings.