Attention is currently required from: laforge, lynxis, pespin.
View Change
1 comment:
File src/slotmap.c:
Patch Set #7, Line 123: map_found = map;
why keep iterating here once found? is there any rationale to picking the last one instead of the fi […]
The list is not sorted. I need to iterate through all entries, to see if there is another mapping to the same bank/slot with higher priority. I return the highest priority map found.
To view, visit change 43743. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ibc9f771cda5d3ba94934cb04e00e60acd466e8bf
Gerrit-Change-Number: 43743
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: lynxis <lynxis@fe80.eu>
Gerrit-Comment-Date: Fri, 13 Nov 2026 13:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>