Attention is currently required from: fixeria, dexter.
View Change
1 comment:
File pySim/cdma_ruim.py:
Patch Set #1, Line 136: HexAdapter
Not sure if we want hex here, I would just change `'0000'` to `b'0000'` above.
we *always* want Hex, as bytes cannot be serialized to JSON. It's always wrapped in HexAdapter or BytesAdapter. See all the other existing code.
To view, visit change 33704. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icdf4621eb68d05a4948ae9efeb81a007d48e1bb7
Gerrit-Change-Number: 33704
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Jul 2023 19:34:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment