lynxis lazus submitted this change.
gprs_gmm: Service Request: add FIXME to check authentication
Before parsing the PDP status of a Service Request, the Service Request has
to be authenticated, otherwise it is possible to close a UE's PDP context by
sending a fake Service Request.
Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2
---
M src/sgsn/gprs_gmm.c
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index 84c6387..976e710 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -1945,6 +1945,7 @@
/* TODO: Use tlvp_val16le when available */
uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));
+ /* FIXME: this should be done after the connection has been authenticated! */
process_ms_ctx_status(ctx, pdp_status);
/* 3GPP TS 24.008 ยง 4.7.13.4 Service request procedure not
To view, visit change 43598. To unsubscribe, or for help writing mail filters, visit settings.