Attention is currently required from: falconia.
Patch set 2:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #2, Line 16:
The case of TCH/H is still unhandled, and it may or may not be
possible to handle correctly, particularly for rtp always-output mode.
The fundamental difficulty is that in order to produce truly
undisrupted RTP timing, two BFI packets will need to be sent for
one FACCH, spaced 20 ms apart - but if the PHY only sends one
GsmL1_Sapi_FacchH message surrounded by a 40 ms time gap, then
we may be out of luck.
- might make sense to add this as a comment into/above the if-clause that treats FACCH/F but not FACCH/H
- in FACCH/H you could still send that second RTP packet, but with a high jitter?
To view, visit change 32100. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I39d15faade28fb7d670493a99a0e0bdb654e2a4a
Gerrit-Change-Number: 32100
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: falconia <falcon@freecalypso.org>
Gerrit-Comment-Date: Tue, 28 Mar 2023 12:28:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment