Attention is currently required from: laforge, pespin.
View Change
1 comment:
File bts/BTS_Tests.ttcn:
Patch Set #2, Line 786: RSL PDU
port RSL_DCHAN_PT RSL; […]
I suggest saying "RSL port message" in both cases:
- RSL.receive(RSL_Message:?) -- Rx unexpected RSL port message: ...
- RSL.receive -- Rx unexpected RSL port message
In the first case you're specifically catching a record of type RSL_Message, so you print it. In the second case you print nothing, because you're basically catching anything. Yes, all port messages carry RSL PDUs at the moment, but we may add some special ones some day...
To view, visit change 29582. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4
Gerrit-Change-Number: 29582
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Oct 2022 09:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment