fixeria has uploaded this change for review.

View Change

osmo-bts-trx: document/clarify the meaning of BUFMAX=24

Change-Id: I95d4e4ee3938cfabc1695959cc82a1efbbf0d7ed
Related: OS#1572
---
M include/osmo-bts/scheduler.h
M src/osmo-bts-trx/sched_utils.h
2 files changed, 14 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/26/33726/1

diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h
index 23d01fb..94333ea 100644
--- a/include/osmo-bts/scheduler.h
+++ b/include/osmo-bts/scheduler.h
@@ -132,7 +132,7 @@
 	/* Uplink measurements */
 	struct {
 		/* Active channel measurements (simple ring buffer) */
-		struct l1sched_meas_set buf[24]; /* up to 24 entries */
+		struct l1sched_meas_set buf[24]; /* up to 24 (BUFMAX) entries */
 		unsigned int current; /* current position */
 
 		/* Interference measurements */
diff --git a/src/osmo-bts-trx/sched_utils.h b/src/osmo-bts-trx/sched_utils.h
index 4521a2e..4091168 100644
--- a/src/osmo-bts-trx/sched_utils.h
+++ b/src/osmo-bts-trx/sched_utils.h
@@ -26,7 +26,9 @@
 /* Burst Payload LENgth (short alias) */
 #define BPLEN GSM_NBITS_NB_GMSK_PAYLOAD
 
-/* Burst BUFfer capacity (in BPLEN units) */
+/* Burst BUFfer capacity (in BPLEN units).  Why 24?  Because CSD frames
+ * are interleaved over 22 bursts, but on TCH/F we decode every 4th burst,
+ * so it must be a multiple of 4.  See also 'doc/trx_sched_tch.txt'. */
 #define BUFMAX 24
 
 /* Burst BUFfer position macros */

To view, visit change 33726. To unsubscribe, or for help writing mail filters, visit settings.