Attention is currently required from: pespin.
View Change
1 comment:
File src/stream.c:
Patch Set #1, Line 472: osmo_fd_write_disable(&cli->ofd);
what if connect_cb() freed the cli object? you'd be accessing it here. […]
Please look at osmo_iofd_free() and osmo_iofd_close()
iofd->in_callback guards these
To view, visit change 33253. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I418377eabd465ee4ffce9b4440e96287c7734924
Gerrit-Change-Number: 33253
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Jun 2023 13:51:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment