Attention is currently required from: Timur Davydov, laforge, neels, pespin.

View Change

11 comments:

• Patchset:

  • Patch Set #21:

    Marking threads resolved.

• File configure.ac:

  • Patch Set #16, Line 259: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes" && test "x$emscripten" != "xyes")

    Done. I’ve sent a separate patch addressing this, preceding this one.

    Done

• File include/osmocom/core/logging.h:

  • Patch Set #5, Line 285: LOG_TGT_TYPE_WEB, /*!< Web logging */

    Thanks for the clarification. […]

    Done

• File src/core/Makefile.am:

  • Patch Set #7, Line 49: logging_emscripten.c \

    Thanks for the suggestion, agreed. […]

    Done

• File src/core/Makefile.am:

  • Patch Set #16, Line 87: if ENABLE_TUN

    Agreed, this likely needs an additional fix. This should follow the same […]

    Done

• File src/core/logging_emscripten.c:

  • Patch Set #7, Line 24: /*! \addtogroup logging

    Please make sure you rebase your work on top of current master, I did some changes to configure. […]

    Done

• File src/vty/logging_vty.c:

  • Patch Set #5, Line 907: #if !defined(__EMSCRIPTEN__)

    The conditional compilation here was added by mistake — it's not needed in this place. […]

    Done

  • Patch Set #5, Line 1038: DEFUN(cfg_log_web, cfg_log_web_cmd,

    Thanks — added conditional compilation `#if defined(__EMSCRIPTEN__)`

    Done

  • Patch Set #5, Line 1047: vty_out(vty, "%% Unable to create WEB log for %s", VTY_NEWLINE);

    Thanks, fixed

    Done

  • Patch Set #5, Line 1067: vty_out(vty, "%% Unable to find WEB log target for %s", VTY_NEWLINE);

    Thanks, fixed

    Done

• File src/vty/logging_vty.c:

  • Patch Set #16, Line 937: #if !defined(__EMSCRIPTEN__)

    Agreed. I disabled it only to avoid creating files on the Web side, but since […]

    Done

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.