Attention is currently required from: falconia, pespin.

View Change

2 comments:

• File src/common/l1sap.c:

  • Patch Set #1, Line 1270: case GSM_HR_BYTES_RTP_RFC5993:

    so here we remove the ToC information. […]

    the question is: do we have any existing code that would require it? It's not really useful to think about hypothetical constraints by theoretical future other DSP Backends. We're in 2023 and it is very unlikely that there will still be people developing new GSM BTS hardware for osmo-bts...

  • Patch Set #1, Line 1279:

    memmove(msg->data, msg->data + 1, GSM_HR_BYTES);
    		msgb_get(msg, 1);
    

    I'm wondering why we are moving data around in the msgb? This is potentially quite expensive on our poor ARM926 based platforms, thinking of doing this for 14 TCH/H channels, for each RTP frame.

    Can't we simply msgb_pull(msg, 1), i.e. make the pointers to the start of the message point one byte further into the msgb?

To view, visit change 32968. To unsubscribe, or for help writing mail filters, visit settings.