Attention is currently required from: laforge, pespin.
View Change
1 comment:
Patchset:
Patch Set #1:
Maybe make this filtering optional through a cmd arg?
I see no practical use for keeping SETSLOT based filtering:
- osmo-bts-trx is usually activating all timeslots, except those explicitly disabled in `osmo-bsc.cfg` and/or masked out in `osmo-bts.cfg` (see the `slotmask` command). This is rarely used AFAIK, perhaps only for CalypsoBTS?
- for trxcon we *need* to receive on all timeslots in order to generate NOPE.inds.
As an option, I can update this patch and keep the filtering only for bursts being sent by a transceiver (i.e. UL bursts for trxcon, and DL bursts for osmo-bts) and unconditionally pass all received bursts, but this makes a little sense IMO.
To view, visit change 33165. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia42550d5c2d8b49efbdf8ef0ce46b26afd1c464e
Gerrit-Change-Number: 33165
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Jun 2023 14:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment