neels submitted this change.

View Change


Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
coverity: fix type of local var

osmo_sccp_instance_next_conn_id() may return negative on error, so use
int instead of uint.

Fixup for recent 548d3d2f6639b728710b9a1905087a189f47de78
'use new osmo_sccp_instance_next_conn_id()'

Related: CID#316694
Change-Id: I2623c06c23691acb75f6ee6ff3a42ac7d10a4b1f
---
M src/osmo-hnbgw/context_map.c
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/osmo-hnbgw/context_map.c b/src/osmo-hnbgw/context_map.c
index cdc526b..2af685e 100644
--- a/src/osmo-hnbgw/context_map.c
+++ b/src/osmo-hnbgw/context_map.c
@@ -57,7 +57,7 @@
bool is_ps)
{
struct hnbgw_context_map *map;
- uint32_t new_scu_conn_id;
+ int new_scu_conn_id;
struct hnbgw_cnlink *cnlink;
struct hnbgw_sccp_user *hsu;


To view, visit change 33158. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I2623c06c23691acb75f6ee6ff3a42ac7d10a4b1f
Gerrit-Change-Number: 33158
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged