Attention is currently required from: osmith, Hoernchen, neels, laforge, fixeria, daniel.

View Change

4 comments:

• File src/osmo_io.c:

  • Patch Set #3, Line 50: struct iofd_backend_ops g_iofd_ops;

    This should be resolved if we end up introducing a . […]

    if a map file is introduced, this symbol will still be exported in order to be used by tests AFAIU. And what we want to avoid is exporting symbols not prefixed with osmo_ which would collide with other libs.

  • Patch Set #3, Line 111: talloc_free(msghdr);

    For io_uring the msghdr will also be used for read requests and then the msg might continue to live […]

    Better describe it in the code then.

  • Patch Set #3, Line 225: msg_pending = iofd_msgb_alloc(iofd);

    This path is chosen if we receive more than one message. […]

    Ack. Better describe this in the code.

  • Patch Set #3, Line 228: iofd->pending = msg_pending;

    you may want to add OSMO_ASSERT(iofd->pending == NULL) perhaps.

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.