Attention is currently required from: laforge, pespin, fixeria, msuraev.
Patch set 11:Code-Review -2
2 comments:
Patchset:
I'm still not following why do we need this function. […]
also possible to pass in an osmo_sockaddr with the port set to zero beforehand
File src/core/socket.c:
Patch Set #11, Line 1957: OSMO_STRBUF_PRINTF(sb, "[");
I strongly disagree with Pau's earlier review here!
We cannot change the previous behavior of osmo_sockaddr_to_str_buf2() -- after this patch, version 2 must continue to print the square braces, also when omitting a port number.
This has implications for regression tests' output testing, merging this patch likely fires up red builds all over the place.
If the new function should omit braces, then version 3 must be a separate implementation, while version 2 remains unchanged. Very important, this.
(My personal opinion is that always printing square braces is a good idea anyway, but that doesn't really matter much for this point)
To view, visit change 28995. To unsubscribe, or for help writing mail filters, visit settings.