laforge submitted this change.

View Change

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
onomondo_eim_app: add TODO to improve logger

Related: SYS#8100
Change-Id: Ia3b35f81d2a1eb0732d55678d553902bb562fd6d
---
M src/onomondo_eim_app.erl
1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl
index 1d8c73f..07a2ed6 100644
--- a/src/onomondo_eim_app.erl
+++ b/src/onomondo_eim_app.erl
@@ -98,6 +98,10 @@

start(_Type, _Args) ->
{ok, Vsn} = application:get_key(onomondo_eim, vsn),
+
+ % TODO: Improve logging: The current use of log messages and format-strings is very bulky to handle. We should find
+ % something more effective here. A short explanatory text with the context attached as a map would be much more
+ % effective than fumbling with string format arguments.
logger:notice("eIM! version: ~s~n", [Vsn]),

% Startup database

To view, visit change 43503. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b35f81d2a1eb0732d55678d553902bb562fd6d
Gerrit-Change-Number: 43503
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>