Attention is currently required from: arehbein, daniel.
Patch set 5:Code-Review -1
View Change
2 comments:
File src/gsm/ipa.c:
Patch Set #5, Line 722: int ipa_segmentation_cb(struct msgb *msg)
This definetly requires documentation on params, return code, behavior, etc.
Patch Set #5, Line 725: /* Haven't even the read entire header */
this sentence looks wrongly written
To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f
Gerrit-Change-Number: 33083
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: daniel <dwillmann@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jun 2023 11:12:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment