Attention is currently required from: osmith.

View Change

2 comments:

• File pySim/esim/saip/__init__.py:

  • Patch Set #3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None:

    maybe it would be useful if this function printed which instances of NAAs it removed?

    I don't like printing by library functions in general, this kind of code might very well be executed in an environment without a console. In tems of returning: The questions is what should it return? The number of matching NAAs removed would be an idea, but then there are many different items removed at various different locations. Which one should count, and which not?

  • Patch Set #3, Line 573:

    if template in hdr.decoded['eUICC-Mandatory-GFSTEList']:
                    hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)]
    

    just to be sure: it cannot be that `template.prefix_match() is True` for any element of `hdr. […]

    I'm not following you here, sorry.

To view, visit change 37010. To unsubscribe, or for help writing mail filters, visit settings.