laforge submitted this change.

View Change


Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified Objections: pespin: I would prefer this is not merged as is
ts_51_011: fix EF_ServiceTable: use self for static method

Even though _bit_byte_offset_for_service() is a @staticmethod, it's
still available via self, just like any non-static method.

Change-Id: I3590dda341d534deb1b7f4743ea31ab16dbd6912
---
M pySim/ts_51_011.py
1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py
index 3dc21c8..222bdaf 100644
--- a/pySim/ts_51_011.py
+++ b/pySim/ts_51_011.py
@@ -670,16 +670,14 @@
bin_len = 0
for srv in in_json.keys():
service_nr = int(srv)
- (byte_offset, bit_offset) = EF_ServiceTable._bit_byte_offset_for_service(
- service_nr)
+ (byte_offset, bit_offset) = self._bit_byte_offset_for_service(service_nr)
if byte_offset >= bin_len:
bin_len = byte_offset+1
# encode the actual data
out = bytearray(b'\x00' * bin_len)
for srv in in_json.keys():
service_nr = int(srv)
- (byte_offset, bit_offset) = EF_ServiceTable._bit_byte_offset_for_service(
- service_nr)
+ (byte_offset, bit_offset) = self._bit_byte_offset_for_service(service_nr)
bits = 0
if in_json[srv]['allocated'] == True:
bits |= 1

To view, visit change 32406. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3590dda341d534deb1b7f4743ea31ab16dbd6912
Gerrit-Change-Number: 32406
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged