Attention is currently required from: neels.
4 comments:
Patchset:
I think with this you are only sorting out one of the concurrency problems when using rate_ctr/stats. What if for instance a rate_ctr_group is destroyed or added meanwhile? there's several linked lists in there.
Did you look at osmo_itq already to pass the updated counters instead?
File src/core/stats.c:
Patch Set #1, Line 808: pthread_mutex_destroy(g_report_lock);
What happens if a pthread_mutex is destroyed while used?
Probably missing some API documentation about this needing to be called during program startup while only 1 thread exists to avoid problems.
Patch Set #1, Line 819: void osmo_stats_report_lock(bool lock)
I'd definetly have 2 APIs here, one for lock and one for unlock.
Easier to read and trace in lots of different ways.
Patch Set #1, Line 831: pthread_mutex_t *lock = g_report_lock;
what's the point of this local variable?
To view, visit change 36538. To unsubscribe, or for help writing mail filters, visit settings.