Attention is currently required from: osmith, Hoernchen, neels, laforge, pespin, fixeria.

View Change

2 comments:

• File src/core/osmo_io_internal.h:

  • Patch Set #14, Line 40: /*! flags to guard closing/freeing of iofd */

    Not saying this needs to be done, but IMO a bitmask would be a better fit here because adding new fl […]

    Sounds good, I added a TODO in my local repo so I don't forget. Still like to push this for now.

• File src/core/osmo_io_poll.c:

  • Patch Set #14, Line 44: inline

    Do we really need to force inlining here? Given that this function is used only once, compilers will […]

    Sure, we can always re-add it if it becomes an issue

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.