Attention is currently required from: arehbein, laforge, pespin.

Patch set 12:Code-Review +1

View Change

2 comments:

• File src/common/pcu_sock.c:

  • Patch Set #6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m);

    Hope this is alright now. […]

    Ack

• File src/common/pcu_sock.c:

  • Patch Set #12, Line 1117: if (errno == EAGAIN)

    you could: "return errno == EAGAIN ? -EAGAIN : -1;" but fine anyway.

    This is just a matter of personal preferences, I am fine with the `if`.

To view, visit change 31533. To unsubscribe, or for help writing mail filters, visit settings.