Attention is currently required from: laforge, pespin.

View Change

1 comment:

• File src/common/measurement.c:

  • Patch Set #3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n",

    This is totally weird. You are passing lchan before DMEAS and LOGL_ERROR, but "fn" afterwards. […]

    I would not say "totally"... The current approach is consistent with both LOGPLCHAN and LOGPFN macros: the former accepts lchan as the first argument, the later accepts fn after the logging level. Personally I don't really care, as long as it's more or less consistent.

To view, visit change 32087. To unsubscribe, or for help writing mail filters, visit settings.