Attention is currently required from: daniel, laforge, pespin.
3 comments:
Patchset:
This patch didn't really introduce the (possible) issues I'm addressing here, but I think it would be better if we fixed them while we're at it
File src/stream_srv.c:
Patch Set #2, Line 489: if (OSMO_UNLIKELY(res <= 0)) {
Why do we not call `osmo_stream_srv_clear_tx_queue()` here, if the connection is dead anyways?
Patch Set #2, Line 496: if (osmo_iofd_txqueue_len(iofd) == 0)
Can it not happen that messages can't be sent out, so that this condition never holds true? In that case, the connection won't be closed as announced (I think this is a problem without this change, as well).
Also, `osmo_stream_srv_clear_tx_queue()` isn't called anywhere except in `osmo-hnbgw.git:src/osmo-hnbgw/hnbgw.c` on connection restart (or something among those lines) as far as I can tell, so if messages can't be sent out and `OSMO_STREAM_SRV_F_FLUSH_DESTROY` is set, then it looks like we will have some sort of endless loop here.
To view, visit change 34338. To unsubscribe, or for help writing mail filters, visit settings.