Attention is currently required from: fixeria, laforge.
View Change
1 comment:
Patchset:
Patch Set #1:
Acknowledged, but can be merged as-is and further improved later.
Here we do not need it for performance. We only need to move the logic into one place because in https://gerrit.osmocom.org/c/osmocom-bb/+/40055 str remote_addr + remote_port will be changed to sole `struct sockaddr_in remote_addr` and without keeping the logic in one place we will need to update all users.
I used a function, because `.desc_link()` is already a function, not a property.
To view, visit change 40046. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe
Gerrit-Change-Number: 40046
Gerrit-PatchSet: 1
Gerrit-Owner: kirr <kirr@nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Apr 2025 13:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>