Attention is currently required from: laforge, pespin, fixeria.
View Change
2 comments:
File src/common/l1sap.c:
Patch Set #1, Line 1261: resp_msg->len != GSM_HR_BYTES + 1
You can actually have 1 conditional block level less, all of it under UNLIKELY: […]
Done
Patch Set #1, Line 1268: resp_msg->len != GSM_HR_BYTES
makes sense to use OSMO_UNLIKELY here
Done
To view, visit change 31417. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Feb 2023 15:09:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment