Attention is currently required from: osmith.

View Change

2 comments:

• File src/mslookup/mdns_rfc.c:

  • Patch Set #1, Line 80: if (osmo_apn_from_str(buf, buf_len, qst->domain) < 0)

    so in here you are assuming that encoding the string into the msg will take always exactly strlen(qst->domain) + 1.
    Is that correct to assume?

  • Patch Set #1, Line 105: ret->domain = talloc_size(ret, qname_len - 1);

    I'd expect the string to be longer than the buffer due to \0? Is this correct?

To view, visit change 30777. To unsubscribe, or for help writing mail filters, visit settings.