Attention is currently required from: fixeria.
Patch set 3:Code-Review -1
6 comments:
Patchset:
This patch looks correct to me but it needs polishing.
File pySim/global_platform/__init__.py:
Patch Set #3, Line 901: # `--install-parameters-*` are all optional
Better fix this in the patch before.
File pySim/global_platform/install_param.py:
Patch Set #3, Line 58: if non_volatile_memory_quota and volatile_memory_quota and stk_parameter:
I think the error here is that it should be 'or' instead of 'and'. Only then the following code makes sense.
this looks correct, but I would add some comments to make the code easier to understand:
# collect system specific parameters (optional)
Patch Set #3, Line 67: system_specific_params.append({'stk_parameter': stk_parameter})
# If system specific parameters are present, add them to the install parameters
File tests/unittests/test_globalplatform.py:
Patch Set #3, Line 298: load_parameters = gen_install_parameters()
interesting that this does not change in behavior.
To view, visit change 42378. To unsubscribe, or for help writing mail filters, visit settings.